Skip to content

providers/ipa/: add_v1_user_data() amended#890

Closed
alexey-tikhonov wants to merge 1 commit intoSSSD:masterfrom
alexey-tikhonov:4078_coverity
Closed

providers/ipa/: add_v1_user_data() amended#890
alexey-tikhonov wants to merge 1 commit intoSSSD:masterfrom
alexey-tikhonov:4078_coverity

Conversation

@alexey-tikhonov
Copy link
Member

Fixes few mistypes and compilation warning:

sssd-2.2.3/src/providers/ipa/ipa_s2n_exop.c:665:20: warning: 'gc' may be used uninitialized in this function [-Wmaybe-uninitialized]
     attrs->ngroups = gc;
     ~~~~~~~~~~~~~~~^~~~

@sumit-bose
Copy link
Contributor

Hi @alexey-tikhonov,

thanks for the fix, can you add Related to https://pagure.io/SSSD/sssd/issue/4078 to the commit message and apply the patch to the master branch instead, so that it can be backported to sssd-1.16 (instead of being ported forward)?.

bye,
Sumit

Fixes few mistypes and compilation warning:
```
sssd-2.2.3/src/providers/ipa/ipa_s2n_exop.c:665:20: warning: 'gc' may be used uninitialized in this function [-Wmaybe-uninitialized]
     attrs->ngroups = gc;
     ~~~~~~~~~~~~~~~^~~~
```

Related to https://pagure.io/SSSD/sssd/issue/4078
@alexey-tikhonov
Copy link
Member Author

can you add Related to https://pagure.io/SSSD/sssd/issue/4078 to the commit message

Done.

and apply the patch to the master branch instead, so that it can be backported to sssd-1.16 (instead of being ported forward)?.

Not sure I understand this part. PR is against master.

May be I misused branch: sssd-1-16 label. I meant this PR should be back-ported to 1-16 as well (without separate PR)

@sumit-bose
Copy link
Contributor

May be I misused branch: sssd-1-16 label. I meant this PR should be back-ported to 1-16 as well (without separate PR)

Sorry, this misunderstanding was on my side. All is fine. ACK

bye,
Sumit

@pbrezina
Copy link
Member

  • master
    • 39e16cc - providers/ipa/: add_v1_user_data() amended
  • sssd-1-16
    • e294f73 - providers/ipa/: add_v1_user_data() amended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants