feat(parity): add manifest-declared v2 gate exclusions (#90 PR 8b) - #105
Merged
Conversation
Let a v2 parity manifest declare selected gates measured-but-not- blocking via an optional gate_exclusions array. Every gate is still measured and reported; eligibility is computed over the new blocking_failed_gates (failed minus excluded), and scorecard plus scoreboard echo excluded_gates/blocking_failed_gates as required fields so an exclusion-assisted pass cannot be mistaken for a full pass. With no exclusions declared the schemas keep the legacy strict rule, so the public CI profile is validated exactly as before. Also documents the residual private-profile gaps (text, raster, roi) as content-free aggregates in 21-pdf-parity, adds the private Hancom-receipt and parity gate items to release-readiness, records PRs 7a/7b/8a/8b in the feature-gap history, and refreshes the stale CELL-pagination note in 05-rendering (EN+KO).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd6be62c5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The v2 scorecard and scoreboard schemas now enforce, for each of the eight gates, that a failed non-excluded gate must appear in blocking_failed_gates and that a blocking gate must be failed and not excluded, so a scorecard can no longer validate an exclusion-assisted pass over a non-excluded failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Epic #90 PR 8b: explicit, auditable gate exclusions for the v2 parity contract, plus the certification/documentation/release-gate doc sweep.
passed_gates/failed_gatesare unchanged; eligibility follows the newblocking_failed_gates(failed minus excluded). Scorecard and scoreboard echoexcluded_gates+blocking_failed_gatesas required fields; with no exclusions the schemas keep the legacy strict rule, so the public CI profile is behaviorally unchanged (fixtures updated with empty arrays).page_count/media_box/render_issues/determinism, declaresfontsexcluded, and still blocks ontext/raster/roi. Content-free aggregate analysis recorded indocs/design/21-pdf-paritysection 4.4: text deltas are extraction order plus a small fixed symbol/ASCII set (99.17% char-multiset identical, zero Hangul differences); raster divergence is uniform across pages (consistent with the 8 known font substitutions) plus two layout-shift pages; only the page-2 diagram ROI fails. Fixes deferred.Verification
scripts/check.shOK (public parity skip on the Poppler pin as usual).tools/test_pdf_parity.pytests including 4 new exclusion tests; schema smoke checks confirm an exclusion-assisted pass validates while a hidden one fails.blocking_failed_gates = [text, raster, roi], exit 1 as documented.Epic #90 stays open: text/raster/roi fixes, approved font faces, and the independent Hancom verification receipt remain.