Skip to content

Mortgage Calc v2 error word doc#145

Merged
jenbreese merged 2 commits into
devfrom
error-doc-mortgage-cal-v2
Jul 2, 2026
Merged

Mortgage Calc v2 error word doc#145
jenbreese merged 2 commits into
devfrom
error-doc-mortgage-cal-v2

Conversation

@jenbreese

@jenbreese jenbreese commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

READY FOR REVIEW

Summary

Shared fields

  1. Interest rate: empty error (touched-gated per Rachel's note) and 0 to 20 inclusive range error. Also stopped silently clamping negatives so the range message can actually fire.
  2. Down payment %: 0 to 99.9 inclusive range error.
  3. Property tax % and insurance %: 0 to 10 inclusive range errors.
  4. Property tax $ and insurance $: relative 10%-of-home-price cap errors (uses calculatedHomePrice on Tab 1, homePriceon Tab 2).
  5. HOA dues: 0 to 20,000 inclusive. Removed the old silent clamp (Tab 1 was clamping to 100,000, Tab 2 unbounded) so out-of-range now blocks with a message.

Tab 1

  1. Row 15 monthly payment empty error; Row 16 hard cap $1 to $1,000,000 (0 and negatives rejected).
  2. Row 18 dollar down payment absolute ceiling 0 to 1,000,000,000.
  3. Row 19 output backstop: if the estimate runs away (non-finite or past a display ceiling) it shows the "payment too high" message instead of a garbage number.

Tab 2

  1. Row 20 home price empty error; Row 22 range $1 to $1,000,000,000 inclusive.
  2. Row 23 negative down payment message; Row 24 dollar down payment >= home price now blocks with an error. I removed the clampDownPaymentAmount calls that were silently capping it, since that clamp made Row 24 impossible to trigger.

Cross-tab

  1. Note 3: killed the page-level red banner and moved everything to inline role="alert" messages next to each field, with aria-invalid and aria-describedby wired up and the border turning red on error.
  2. Note 4: no more silent resets. Every blocked field carries a visible message.
  3. Governing rule (result OR warning, never both): results panel now shows results only when clean, a warning message on a genuine bad value, or a blank "enter values" placeholder for untouched/empty-required. No stale numbers.

@majimmy88 majimmy88 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenbreese jenbreese merged commit a9fe346 into dev Jul 2, 2026
@jenbreese jenbreese mentioned this pull request Jul 10, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants