Skip to content

Inflation 709#151

Merged
jenbreese merged 5 commits into
devfrom
inflation-709
Jul 9, 2026
Merged

Inflation 709#151
jenbreese merged 5 commits into
devfrom
inflation-709

Conversation

@jenbreese

Copy link
Copy Markdown
Collaborator

READY FOR REVIEW

Summary

Two initial-price field fixes on the Inflation Impact Calculator:

  1. The empty-field prompt no longer fires mid-edit. Clearing the field while
    focused shows nothing; the prompt appears only after the user leaves the
    field (blur). Range errors still show live.
  2. Negative entries are kept and shown instead of being silently stripped.
    Typing -1000 now displays -1,000 and surfaces the range warning
    ("Enter an amount between $0.01 and $1,000,000,000.") immediately, so the
    user sees exactly what they typed alongside the mistake.

Review By (Date)

  • [date]

Criticality

  • 3/10. Scoped to one field on one interactive (Inflation Impact Calculator).
    No math or data changes; input-validation UX only.

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch and open the Inflation Impact Calculator.
  2. Empty-on-blur: clear the Initial price field. Confirm no error shows while
    the field is still focused and the result shows the "-" placeholder. Click
    away and confirm the empty prompt appears.
  3. Negative entry: type -1000. Confirm the field shows -1,000 (not a
    stripped 1,000) and the range warning shows live, before blur.
  4. Recovery: replace the negative with a valid amount and confirm the warning
    clears and the result recalculates.
  5. Range bounds still enforced: values below $0.01 or above $1,000,000,000
    trigger the range warning.

Front End Validation

  • Markup uses appropriate semantic tags and passes HTML validation
  • Cross-browser testing performed
  • Automated accessibility scans performed (aria-invalid tracks the visible
    error state, so an empty pre-blur field is not announced as invalid)
  • Manual accessibility tests performed (VoiceOver: error announced on blur,
    range error announced live)
  • Design approved by @[reviewer]

Backend / Functional Validation

Code

  • Naming conventions follow our standards
  • Code has sufficient inline comments
  • Nothing hidden or hard to discover through the UI
  • No code smells
  • Tests provided (if applicable)

Code security

  • Inputs handled safely (numeric parse + range guard; no raw passthrough)
  • No new areas for attack

General

  • Nothing included that is unrelated to the problem being solved
  • Approach to the problem is appropriate

Affected Projects or Products

  • ifdm_learning_apps: Inflation Impact Calculator only.

Associated Issues and/or People

  • JIRA ticket(s): [ticket]
  • Other PR: n/a

@majimmy88 majimmy88 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenbreese jenbreese merged commit 7ba090b into dev Jul 9, 2026
@jenbreese jenbreese mentioned this pull request Jul 10, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants