Inflation 709#151
Merged
Merged
Conversation
Error appearing when page just loads.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Two initial-price field fixes on the Inflation Impact Calculator:
focused shows nothing; the prompt appears only after the user leaves the
field (blur). Range errors still show live.
Typing
-1000now displays-1,000and surfaces the range warning("Enter an amount between $0.01 and $1,000,000,000.") immediately, so the
user sees exactly what they typed alongside the mistake.
Review By (Date)
Criticality
No math or data changes; input-validation UX only.
Review Tasks
Setup tasks and/or behavior to test
the field is still focused and the result shows the "-" placeholder. Click
away and confirm the empty prompt appears.
-1000. Confirm the field shows-1,000(not astripped
1,000) and the range warning shows live, before blur.clears and the result recalculates.
trigger the range warning.
Front End Validation
error state, so an empty pre-blur field is not announced as invalid)
range error announced live)
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People