Blocker and High priority fixes#156
Merged
Merged
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the "balance grows if left unpaid" line into the "When you borrow" explanation where it belongs, and switches the calculation to use the fractional periods value the user enters rather than a rounded whole number. Also removes the stray "Rounded to the nearest whole period" info message that was added to the errors doc by mistake.
Changes
!hasError, which made it appear above the results as soon as a valid calculation ran.useMemo.Math.pownow receives the fractional periods directly, so 2.5 periods computes as 2.5, not 3.periodsInfostate and its "Rounded to the nearest whole period for calculation" message entirely (state declaration, reset handler, both change-handler branches, and the message paragraph fallback).Testing