fix(verifier): use credential format from metadata for custom presentation requests - #522
Merged
masv3971 merged 1 commit intoJul 29, 2026
Conversation
…ation requests Custom presentation requests in the verifier UI always hard-coded the DCQL credential format to "dc+sd-jwt". This broke mDoc credentials (e.g. org.iso.18013.5.1.mDL), which must use "mso_mdoc". - Include Format in UICredentialInfo returned by /ui/metadata. - Propagate the format through the UI credential selection state. - Build the custom DCQL credential using the selected credential's actual format instead of the hard-coded default. Fixes SUNET#521
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the verifier UI’s custom presentation request builder so it uses the credential format provided by /ui/metadata instead of always hard-coding dc+sd-jwt, which previously broke mDoc requests that require mso_mdoc (Fixes #521).
Changes:
- Extend
/ui/metadatato includeformatper credential (UICredentialInfo.Format). - Propagate the selected credential’s
formatthrough the UI selection state. - Generate custom DCQL queries using the selected credential’s actual
formatrather than a hard-coded default.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/verifier/staticembed/presentation-definition.js | Adds format to credential metadata parsing/state and uses it when constructing the custom DCQL credential. |
| internal/verifier/apiv1/handlers_ui.go | Includes Format in the UI credential metadata response derived from configured credential metadata. |
| internal/verifier/apiv1/handlers_ui_test.go | Updates/extends tests to assert that credential format is exposed to the UI from metadata (including an mDoc case). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom presentation requests in the verifier UI always hard-coded the DCQL credential format to "dc+sd-jwt". This broke mDoc credentials (e.g.
org.iso.18013.5.1.mDL), which must usemso_mdoc.FormatinUICredentialInforeturned by/ui/metadata.Fixes #521