Added the possibility to rename the team.

[jloehel]

Screenshot:

Signed-off-by: Jürgen Löhel jloehel@suse.com

[mssola]

Cool 👏 Some comments:

Take a look at the generated activity:

This is not that useful, isn't it? It would be better to say something like: "mssola renamed the team asd to new-name". Basically:

• It's weird to say that you've "edited a name": you "rename" ("changed the name" could work too).
• You should provide what was the previous name, and what's the current name. The link should be on the new name. Note that this can be done through activity parameters.

Second of all, the ChangeName and the ChangeDescription concerns can be merged. They're almost identical. What I would do is:

1. Create a concern named ChangeNameDescription.
2. This concern would have a public method: change_name_description(object, symbol).
3. Depending on the changed column, it would create one kind of activity or another. Note that you can update both the name and the description when performing the update (if the user hasn't changed the name, well, it will update to the same thing :P). With this in mind the implementation should become simpler.

On the implementation of this method, I wouldn't be shy with helper protected methods. That is, take advantage of the similarities between both concerns. Note that you can make this work even for models that do not have an editable name (e.g. Namespace). To be more certain, I'd write a new test like this:

1. Check that it works for a mock model with just an editable description.
2. Check that it works for a mock model with just an editable description.

You don't have to be too exhaustive on this test, but it would be a nice addition.

On the form itself, I'd make the name input "required". This is because a team always has to have a name. Note that this would also work even if the users is just modifying the description.

[mssola]

Add tabindex to 1.

[mssola]

Just fix these small issues and it will be good to go :)

[mssola]

Could you rebase your commit? Right now it has conflicts.