This repository was archived by the owner on Apr 17, 2023. It is now read-only.
feat: simple user creation form#543
Merged
mssola merged 1 commit intoSUSE:masterfrom Nov 11, 2015
Merged
Conversation
salzig
force-pushed
the
feat_create_user
branch
3 times, most recently
from
2c87cca to
5abd90d
Compare
Contributor
Author
There was a problem hiding this comment.
good catch, will change that later.
Collaborator
|
Awesome :) ! I have one issue though. When the admin makes a mistake, it gets displayed like this:
In order to get it properly, you have to change in the line 20 of the render "new"to: redirect_to new_admin_user_path, alert: @user.errors.full_messagesThen it will look like this:
Besides that, everything looks ok to me. I'll update the related issue with a checklist of the steps to get this feature implemented. Thanks for stepping in! |
Contributor
Author
|
|
Collaborator
|
LGTM. Could you squash it into a single commit? |
Contributor
Author
|
Sure, will do that later. |
Signed-off-by: Ben Rexin <ben@rexin.at>
salzig
force-pushed
the
feat_create_user
branch
from
2e6c267 to
fcf20d7
Compare
Contributor
Author
|
done. |
mssola
added a commit
that referenced
this pull request
Nov 11, 2015
feat: simple user creation form
Collaborator
|
@salzig thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: simple user creation form
first steps for #283 and #179