Added the the ability to add comments on repositories

[jloehel]

Screenshots:

Fixes: #204

Signed-off-by: Jürgen Löhel jloehel@suse.com

[mssola]

Good hob 👏. Now, I'm afraid that I'm going to nitpick a bit:

• I don't like that when there are no comments, it's just a "grey" area. You can see that in your first screenshot actually. The background should be white, and there should be a text saying something on the lines of "Nobody has left a comment yet".
• I don't quite like the icon for adding a new comment. Maybe @cyntss can help us with this. Anyways, for now you can just ignore this.
• The "Write a Comment" link is actually not aligned with the "$count Comments" title, when it should. This is due the btn class adding a bit of extra padding. I'm not saying that you should remove this class, but maybe you could polish this. See what I'm saying in the following image:

Now, I'm not so sure about the title. Honestly I would've preferred simple comments: just the text, that's it. This would make the footer of the comment unnecessary, so you could put that information on the header of the comment. Also, in the footer you put something like:

mssola commented on busybox 6 minutes ago

It's redundant to say that I commented on busybox. I'm on the busybox repo already, I know where the comment is. Moreover, since it's easy to do it, I'd also add the profile picture of the user. So, in my opinion, a comment should look like:

• A small header (with little to no padding), no footer.
• The header contains the profile picture, and something like "mssola commented 6 minutes ago". "mssola" should be bold and it should be a link. Just like Github.

Another think I'm not sure about is the icon being used for the activity. I'd prefer any of the 6 icons named comment in font awesome :)

Functionality-wise, the rest looks good to me. Now, let's dive into the code.

[mssola]

This doesn't work. Mainly because it has the fa-user-plus class. Therefore, all this adding/removing of classes just doesn't work for me. Note that this would fix one of my complaints in my previous comment,

[mssola]

Besides all my comments, in the activities you still have the problem that they are going to crash if the repo containing the added/removed comment gets removed. The way to go is:

• Check whether the resource (trackable) actually exists.
  • If it does: use it.
  • Otherwise use what's been stored in the parameters attribute.

[flavio]

Good job @jloehel 👍

Also thanks to @mssola for the code review!

[salzig]

i would say it is better to compare using the user_id field, instead of building the author object which is maybe not needed.

[mssola]

I agree

[mssola]

Remove this since the imported file is empty. And remove the app/assets/stylesheets/comments.scss file as well.
Update: irrelevant now, ignore this.