Fix creation of checksums in customize workflow#302
Merged
dirkmueller merged 3 commits intoSUSE:mainfrom Dec 11, 2025
Merged
Conversation
atanasdinov
requested changes
Dec 11, 2025
dirkmueller
force-pushed
the
checksumming_fix
branch
5 times, most recently
from
feb6296 to
580f0f4
Compare
dirkmueller
force-pushed
the
checksumming_fix
branch
from
580f0f4 to
c2421f1
Compare
davidcassany
approved these changes
Dec 11, 2025
Contributor
davidcassany
left a comment
davidcassany
left a comment
There was a problem hiding this comment.
Nice! Just a couple of small comments. Feel free to ignore them or leave it for later as it can be rearranged when addressing the TODO.
dirkmueller
force-pushed
the
checksumming_fix
branch
from
c2421f1 to
04269a9
Compare
Cannot use go-units FromHumanSize() because we do not follow SI standard in our API. 10G == 10 GiB
The previous path first calculated the checksum and then truncated which led to mismatching checksum. Increase default size to 12G
dirkmueller
force-pushed
the
checksumming_fix
branch
from
04269a9 to
e78d733
Compare
atanasdinov
approved these changes
Dec 11, 2025
ipetrov117
reviewed
Dec 11, 2025
ipetrov117
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.