Skip to content

customize: do not replace extension in --output flag#307

Merged
dirkmueller merged 1 commit intoSUSE:mainfrom
davidcassany:fix_output_extension_management
Dec 11, 2025
Merged

customize: do not replace extension in --output flag#307
dirkmueller merged 1 commit intoSUSE:mainfrom
davidcassany:fix_output_extension_management

Conversation

@davidcassany
Copy link
Copy Markdown
Contributor

@davidcassany davidcassany commented Dec 11, 2025

With #302, as a side effect, #300 got almost fixed, but not entirely. Essentially now running customize command with an output like --output myappliance.img will result on creating an image file named myappliance.raw (or .iso for ISO types). This PR does not replace any eventual extension and it simply appends on it.

So with the current PR flag such as --output myappliance.img would produce myappliance.img.raw for RAW types or myappliance.img.iso for ISOs.

Fixes #300

@davidcassany davidcassany requested a review from a team as a code owner December 11, 2025 15:16
Comment thread internal/cli/cmd/customize.go Outdated
@davidcassany davidcassany force-pushed the fix_output_extension_management branch from 480a35a to 06719b1 Compare December 11, 2025 15:47
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the fix_output_extension_management branch from 06719b1 to 91403d5 Compare December 11, 2025 15:48
@dirkmueller dirkmueller merged commit 0d997bf into SUSE:main Dec 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customize: using a different extension than raw|iso in --output flag causes the build to create wrong artifacts

3 participants