Skip to content

๐Ÿ› Fix: ์•Œ๋ฆผ ์ „์ฒด ์ฝ์Œ ์ฒ˜๋ฆฌ ํ›„ ๋ชจ๋‘ ์ฝ์Œ ์‹ ํ˜ธ๊ฐ€ ์ „๋‹ฌ๋˜์ง€ ์•Š์Œย #327

Description

@si-zero

๐Ÿ› ๏ธ Issue Overview

์•Œ๋ฆผ์„ ๋ชจ๋‘ ์ฝ์œผ๋ฉด ํด๋ผ์ด์–ธํŠธ์— "๋ชจ๋‘ ์ฝ์—ˆ๋‹ค"๋Š” ์‹ ํ˜ธ๋ฅผ ๋‚ด๋ ค์ฃผ๊ธฐ๋กœ ํ–ˆ๋Š”๋ฐ ์ „๋‹ฌ๋˜์ง€ ์•Š๋Š” ๋ฌธ์ œ.

๐Ÿ“ Issue Description

PATCH /api/v1/notifications/read-all์˜ ์‘๋‹ต ํƒ€์ž…์ด ApiResponse<Void>์ด๊ณ , NotificationService.markAllAsRead๊ฐ€ ๋ฐ˜ํ™˜ํ•˜๋Š” ์ฒ˜๋ฆฌ ๊ฑด์ˆ˜๋„ ์ปจํŠธ๋กค๋Ÿฌ์—์„œ ๋ฒ„๋ ค์ง€๊ณ  ์žˆ์–ด "๋ชจ๋‘ ์ฝ์Œ" ๊ด€๋ จ ๊ฐ’์ด ์‘๋‹ต JSON์— ์• ์ดˆ์— ๋‹ด๊ธฐ์ง€ ์•Š์Œ. ๋˜ํ•œ ApiResponse.data๊ฐ€ @JsonInclude(NON_NULL)์ด๋ผ data: null์ธ ๊ฒฝ์šฐ data ํ•„๋“œ ์ž์ฒด๊ฐ€ ์‘๋‹ต์—์„œ ๋น ์ง.

โœ… To do

  • markAllAsRead ์‘๋‹ต์— hasUnread(๋ชจ๋‘ ์ฝ์Œ ์—ฌ๋ถ€) ๊ฐ’์„ ์‹ค์–ด์„œ ๋ฐ˜ํ™˜
  • MockMvc ๊ธฐ๋ฐ˜ ํ†ตํ•ฉ ํ™•์ธ์œผ๋กœ 5๊ฐœ ์•Œ๋ฆผ ์—”๋“œํฌ์ธํŠธ ์‘๋‹ต ์žฌ๊ฒ€์ฆ

Metadata

Metadata

Assignees

No one assigned

    Labels

    ๐Ÿ› Fix (๋ฒ„๊ทธ ์ˆ˜์ •)๋ฒ„๊ทธ๋ฅผ ์ˆ˜์ •ํ•  ๋•Œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค.

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions