Skip to content

malformed URI crashes Sable and won't let you view the room again it was sent in #510

@Sugaryyyy

Description

@Sugaryyyy

Describe the bug

I tried sending a encoded link (was reporting an xss in his website) and now entering a DM crashes sable. https://REDACTED/display/?t=%3Csvg/onload=alert(%22message%C4%99%20glow%C4%99%20message%C5%82message.%22);%3E

Reproduction

  1. Send encoded link
  2. Crash

Expected behavior

No response

Platform and versions

- OS: Linux armv81
- Browser: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/146.0.0.0 Mobile Safari/537.36
- Sable: v1.12.2-dev (8f46cff)

Additional context

Automated Bug Report

Error occurred in the application.

Error Message

URI malformed

Stacktrace

URIError: URI malformed
    at decodeURIComponent (<anonymous>)
    at https://sable.sugary.gay/assets/index-D7zWf1Iz.js:82314:32
    at mI.render (https://sable.sugary.gay/assets/index-D7zWf1Iz.js:62955:65)
    at nDe (https://sable.sugary.gay/assets/index-D7zWf1Iz.js:63238:19)
    at https://sable.sugary.gay/assets/index-D7zWf1Iz.js:63254:46
    at https://sable.sugary.gay/assets/index-D7zWf1Iz.js:250:14
    at https://sable.sugary.gay/assets/index-D7zWf1Iz.js:219:19
    at O (https://sable.sugary.gay/assets/index-D7zWf1Iz.js:203:35)
    at O (https://sable.sugary.gay/assets/index-D7zWf1Iz.js:209:15)
    at B (https://sable.sugary.gay/assets/index-D7zWf1Iz.js:218:14)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingbug/behaviourbehaviour bugbug/confirmedThis bug is confirmed to happen & reproduciblepriority/highan issue of high priority

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions