Skip to content

Decode urls safely to avoid crashes#512

Merged
7w1 merged 4 commits intodevfrom
fix-uri-crash
Mar 24, 2026
Merged

Decode urls safely to avoid crashes#512
7w1 merged 4 commits intodevfrom
fix-uri-crash

Conversation

@7w1
Copy link
Member

@7w1 7w1 commented Mar 24, 2026 •
edited by dozro
Loading

Description

Fixes #510

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@7w1 7w1 requested a review from hazre as a code owner March 24, 2026 14:45
@dozro dozro self-requested a review March 24, 2026 14:52
dozro
dozro reviewed Mar 24, 2026
View reviewed changes
@dozro dozro enabled auto-merge March 24, 2026 14:57
@dozro dozro changed the title Decode urls safely! Decode urls safely to avoid crashes like #510 Mar 24, 2026
@dozro dozro changed the title Decode urls safely to avoid crashes like #510 Decode urls safely to avoid crashes Mar 24, 2026
@7w1
Copy link
Member Author

7w1 commented Mar 24, 2026

such an unnecessary title change smh

@7w1 7w1 disabled auto-merge March 24, 2026 15:00
@7w1 7w1 merged commit fec777a into dev Mar 24, 2026
9 checks passed
@7w1 7w1 deleted the fix-uri-crash branch March 24, 2026 15:00
@dozro
Copy link
Contributor

dozro commented Mar 24, 2026

such an unnecessary title change smh

hehe

@sable-release-bot sable-release-bot bot mentioned this pull request Mar 24, 2026
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-512-sable.raspy-dream-bb1d.workers.dev 6ac65cc pr-512 Tue, 24 Mar 2026 15:00:49 GMT

github-merge-queue bot pushed a commit that referenced this pull request Mar 24, 2026
@7w1
chore: prepare release 1.12.3 (#508)
a418b92 
> [!IMPORTANT]
> Merging this PR will create a new release.

## Fixes

* Fixed text autocomplete issues
([#487](#487) by @nushea)
* Fix crash when url contains malformed/dangling uri components.
([#512](#512) by @7w1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dozro dozro dozro approved these changes

@hazre hazre Awaiting requested review from hazre hazre is a code owner

+1 more reviewer

@rmamet rmamet rmamet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

malformed URI crashes Sable and won't let you view the room again it was sent in

3 participants

@7w1 @dozro @rmamet