Skip to content

Fix timeline items being rerendered constantly#1055

Merged
7w1 merged 1 commit into
devfrom
fix-timeline-rerenders
Jul 11, 2026
Merged

Fix timeline items being rerendered constantly#1055
7w1 merged 1 commit into
devfrom
fix-timeline-rerenders

Conversation

@7w1

@7w1 7w1 commented Jul 11, 2026

Copy link
Copy Markdown
Member

Description

So as Niki pointed out while working on galleries (i think?) timeline items rerender a lot. I never noticed, but uh, turns out this might matter for weaker devices, and comparing them side by side I do actually notice now.

We we're memoizing the components within timeline items, but the timeline items themselves we're being called every single scroll tick, which reduced the efficiency of that inner memoization quite a bit.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@7w1 7w1 requested a review from hazre as a code owner July 11, 2026 05:36
@github-actions

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-1055-sable.raspy-dream-bb1d.workers.dev 47186d8 pr-1055 Sat, 11 Jul 2026 05:37:46 GMT

@7w1 7w1 merged commit 445e90d into dev Jul 11, 2026
12 checks passed
@7w1 7w1 deleted the fix-timeline-rerenders branch July 11, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant