Skip to content

feat: make native title bar a toggle#1188

Merged
hazre merged 3 commits into
SableClient:devfrom
eleboucher:fix/linux-cef-startup
Jul 23, 2026
Merged

feat: make native title bar a toggle#1188
hazre merged 3 commits into
SableClient:devfrom
eleboucher:fix/linux-cef-startup

Conversation

@eleboucher

@eleboucher eleboucher commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a desktop setting to switch between Sable’s custom title bar and native window decorations.

  • Persists the selected title bar mode.
  • Applies it at startup and while running.
  • Keeps connection status in the correct location.
  • Fixes black gaps when resizing the Linux CEF window.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher requested review from 7w1 and hazre as code owners July 21, 2026 21:38
@hazre

hazre commented Jul 22, 2026

Copy link
Copy Markdown
Member

Why? I intentionally made a custom titlebar on windows, so it looks nice and we can have extra functionality, like loading indicator and etc.

also could please follow the PR format unless the title is self explanatory for small changes.

@7w1

7w1 commented Jul 22, 2026

Copy link
Copy Markdown
Member

Getting rid of it on mac might makes sense, on windows imo its better to have it so we can theme it. On linux, idk. People's setups vary just like... add a toggle or something I guess.

@eleboucher
eleboucher force-pushed the fix/linux-cef-startup branch from 386713a to 32aecce Compare July 22, 2026 14:07
@eleboucher eleboucher changed the title refactor(desktop): restore native window chrome feat: make native title bar a toggle Jul 22, 2026
@eleboucher
eleboucher force-pushed the fix/linux-cef-startup branch from 64a1e2d to 9c80420 Compare July 23, 2026 06:42
Comment thread src/app/state/desktopSettings.ts Outdated
Comment thread src/app/features/settings/desktop/Desktop.tsx
Comment thread src-tauri/src/lib.rs
@eleboucher
eleboucher force-pushed the fix/linux-cef-startup branch 2 times, most recently from 2561131 to c8d829b Compare July 23, 2026 09:19
@eleboucher
eleboucher force-pushed the fix/linux-cef-startup branch from c8d829b to 58ee2d1 Compare July 23, 2026 09:28

@hazre hazre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hazre
hazre added this pull request to the merge queue Jul 23, 2026
Merged via the queue into SableClient:dev with commit 62195fc Jul 23, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants