Skip to content

fix(schedule-send): serialize scheduled message cancellation per room - #1564

Merged
7w1 merged 2 commits into
stack/2-keyed-queuefrom
stack/3-schedule-queue
Aug 6, 2026
Merged

fix(schedule-send): serialize scheduled message cancellation per room#1564
7w1 merged 2 commits into
stack/2-keyed-queuefrom
stack/3-schedule-queue

Conversation

@eleboucher

@eleboucher eleboucher commented Aug 1, 2026

Copy link
Copy Markdown
Member

Description

nothing stopped you double-clicking cancel on a scheduled message, and a failed cancel was silent.

cancels go through a per-room queue now, button spinners and disables while in flight, failures show an inline retry.

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher force-pushed the stack/3-schedule-queue branch from 8f62207 to 7060917 Compare August 1, 2026 15:38
@eleboucher
eleboucher force-pushed the stack/3-schedule-queue branch from 7060917 to ae86fab Compare August 4, 2026 09:26
@eleboucher
eleboucher force-pushed the stack/3-schedule-queue branch from ae86fab to 282ff7d Compare August 4, 2026 12:02
@eleboucher
eleboucher force-pushed the stack/3-schedule-queue branch from 282ff7d to 5388d12 Compare August 5, 2026 22:11
@7w1
7w1 force-pushed the stack/3-schedule-queue branch from 5388d12 to 04973d6 Compare August 6, 2026 02:13
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-1564-sable.raspy-dream-bb1d.workers.dev 7f9d042 pr-1564 Thu, 06 Aug 2026 02:31:03 GMT

@7w1
7w1 added this pull request to the merge queue Aug 6, 2026
Merged via the queue into dev with commit ea954f8 Aug 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants