Skip to content

Fix spoilers not being formed when a newline is introduced - #1647

Merged
nushea merged 1 commit into
SableClient:devfrom
j0lol:push-wltvnmoszrqy
Aug 5, 2026
Merged

Fix spoilers not being formed when a newline is introduced#1647
nushea merged 1 commit into
SableClient:devfrom
j0lol:push-wltvnmoszrqy

Conversation

@j0lol

@j0lol j0lol commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes input like:

||foo
bar||
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@j0lol

j0lol commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Drafted because some behavior needs to be worked on. When rendering, the inline-margin causes spoilers on multiple lines to break.

image

Options seem to be:

  • Make separate spoiler spans and link them with JS so they appear the same span
  • Remove the inline-margin
  • Make spoiler rendering block, but this could cause weird issues

@j0lol
j0lol marked this pull request as ready for review August 5, 2026 11:55
@j0lol

j0lol commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Current PR just removes the inline padding

@j0lol
j0lol force-pushed the push-wltvnmoszrqy branch from 25bfae7 to 613af5f Compare August 5, 2026 11:56
@nushea nushea added the internal label Aug 5, 2026
@nushea
nushea enabled auto-merge August 5, 2026 11:57
@nushea
nushea added this pull request to the merge queue Aug 5, 2026
Merged via the queue into SableClient:dev with commit e0f97a5 Aug 5, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants