Skip to content

PMP User Heroes, Fix+Refactor Persona Picker - #1701

Merged
eleboucher merged 7 commits into
SableClient:devfrom
j0lol:push-kzutlxlnspxr
Aug 9, 2026
Merged

PMP User Heroes, Fix+Refactor Persona Picker#1701
eleboucher merged 7 commits into
SableClient:devfrom
j0lol:push-kzutlxlnspxr

Conversation

@j0lol

@j0lol j0lol commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Description

  • Fix rendering issue with Persona Picker in 'Change Persona' submenu
  • Refactor PersonaPicker
  • Add feature that shows PMP information in UserHero, with an option to view the account data instead.

Part of #1279

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@j0lol
j0lol force-pushed the push-kzutlxlnspxr branch from 86bbb40 to 6e34f62 Compare August 9, 2026 11:28
@j0lol
j0lol marked this pull request as ready for review August 9, 2026 12:22
@j0lol
j0lol force-pushed the push-kzutlxlnspxr branch 2 times, most recently from 7352a59 to 22889df Compare August 9, 2026 13:05
@j0lol
j0lol force-pushed the push-kzutlxlnspxr branch 2 times, most recently from ef59e78 to 0a1794b Compare August 9, 2026 14:45
@j0lol j0lol changed the title Fix persona picker displaying wrong in change persona menu & refactor PMP User Heroes, Fix+Refactor Persona Picker Aug 9, 2026
@j0lol
j0lol force-pushed the push-kzutlxlnspxr branch from 0a1794b to c7183fa Compare August 9, 2026 14:47
@j0lol
j0lol force-pushed the push-kzutlxlnspxr branch from c7183fa to 31fa6c4 Compare August 9, 2026 14:54
@j0lol
j0lol force-pushed the push-kzutlxlnspxr branch from 1c992a3 to fe9c5f8 Compare August 9, 2026 15:59
@j0lol
j0lol force-pushed the push-kzutlxlnspxr branch from fe9c5f8 to 97f18d9 Compare August 9, 2026 16:03
@eleboucher
eleboucher added this pull request to the merge queue Aug 9, 2026
Merged via the queue into SableClient:dev with commit 4f9a338 Aug 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants