Skip to content

Fix spoilers leaking emojis and mentions#807

Merged
7w1 merged 1 commit into
devfrom
fix/spoilers-not-spoilering
May 14, 2026
Merged

Fix spoilers leaking emojis and mentions#807
7w1 merged 1 commit into
devfrom
fix/spoilers-not-spoilering

Conversation

@7w1
Copy link
Copy Markdown
Member

@7w1 7w1 commented May 13, 2026

Description

At some point everything (maybe?) other than plaintext got was no longer hidden by spoilers, instead showing on top of them. This fixes that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@7w1 7w1 requested a review from hazre as a code owner May 13, 2026 23:26
@github-actions
Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-807-sable.raspy-dream-bb1d.workers.dev c2c82b5 pr-807 Wed, 13 May 2026 23:28:31 GMT

@7w1 7w1 merged commit 3f47a03 into dev May 14, 2026
12 checks passed
@7w1 7w1 deleted the fix/spoilers-not-spoilering branch May 14, 2026 01:12
nushea pushed a commit to Septicity/Sable that referenced this pull request May 14, 2026
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* Add Space banner support per MSC4221. You can now set it from the
space settings. ([SableClient#801](<SableClient#801>)
by @nushea)
* Add setting to show icons of the rooms in the Rooms sidebar
([SableClient#768](<SableClient#768>) by @nushea)
* Add Resize the sidepanels and the thread height of the original object
using hoverable tools.
([SableClient#768](<SableClient#768>) by @nushea)
* Add toggle to allow one to not join a call in a room by just clicking
it in the sidebar.
([SableClient#768](<SableClient#768>) by @nushea)
* Added the ability to right click on a folder to rename it.
([SableClient#814](<SableClient#814>) by @7w1)
* Upgraded the forward modal to use the same modal present for search
and added the ability to forward to same room the message is from.
([SableClient#808](<SableClient#808>) by @7w1)

### Introduce the new Sable logo!
([SableClient#809](<SableClient#809>) by @Septicity)

- You may need to reinstall PWAs to recieve the new app icons, if you
use them.
- Our logo is [licensed under
CC0](https://github.com/SableClient/Sable/blob/dev/TRADEMARKS.md), aka
do whatever you want with it!
- Also, there's a script for other us or other forks to replace the icon
in the future, if needed.

## Fixes

* Add graceful fail if MSC4140 event delay exceeded
([SableClient#276](<SableClient#276>) by
@jasonlaguidice)
* Drops paragraph tags when messages are only a single paragraph, use
markdown (two new lines) to define a new paragraph rather than a line
break. ([SableClient#799](<SableClient#799>) by @7w1)
* Fixed the text wrapping behavior of fallback messages.
([SableClient#806](<SableClient#806>) by @7w1)
* Fixed the thin line appearing at the top of unstyled profiles.
([SableClient#803](<SableClient#803>) by @7w1)
* Matrix.to links sent without explicit markdown formatting are sent as
raw links instead of html links.
([SableClient#786](<SableClient#786>) by @7w1)
* Fix `/myroomnick` and room cosmetics display name not updating name.
([SableClient#805](<SableClient#805>) by @7w1)
* Fix spoilers not hiding nested content like mentions, emoji images,
and custom-colored spans.
([SableClient#807](<SableClient#807>) by @7w1)
* Added svgs to the allowed embeds for rendering/sending.
([SableClient#804](<SableClient#804>) by @7w1)
* Suppress timeline dividers when there's no rendered events between
them. ([SableClient#720](<SableClient#720>) by
@mvanhorn)
* Improve thread drawer separation between the pinned root message and
replies with a border.
([SableClient#830](<SableClient#830>) by @7w1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant