Skip to content

Comments

W-8988823 Require Apex code coverage#180

Merged
spelak-salesforce merged 2 commits intofeature/240from
feature/240__apex-code-coverage
May 9, 2022
Merged

W-8988823 Require Apex code coverage#180
spelak-salesforce merged 2 commits intofeature/240from
feature/240__apex-code-coverage

Conversation

@spelak-salesforce
Copy link
Contributor

@spelak-salesforce spelak-salesforce commented May 5, 2022

W-8988823

Requires each Apex class to have at least 95% code coverage.

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

Requires each Apex class to have at least 95% code coverage.
@spelak-salesforce spelak-salesforce added the ready for QE This item is ready for testing label May 5, 2022
@spelak-salesforce spelak-salesforce requested a review from a team as a code owner May 5, 2022 13:31
@spelak-salesforce spelak-salesforce requested review from davidmreed and removed request for a team May 5, 2022 13:31
@spelak-salesforce spelak-salesforce self-assigned this May 5, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

Hi 👋 @spelak-salesforce! Release Engineering asks that teams use the following process for routine reviews:

  1. After creating a non-draft pull request that includes automation updates, a release engineer will be auto-assigned to the PR.
  2. When dev review is complete and the PR is ready for the release engineer to review, add a "ready for RE review" label to the PR to let us know when the PR is ready for us to review.
  3. If you've added the "ready for RE review" label but haven't received a review within a 36 hours, @-mention the assigned RE in a comment on the PR.
  4. If you don't receive a response from the assigned RE by the end of the next business day (or your request is urgent), post a message to #sfdo-releng-support that includes a link to this PR and one of us will review as soon as we're able.

@spelak-salesforce spelak-salesforce requested a review from sella24 May 5, 2022 13:34
@spelak-salesforce spelak-salesforce added the ready for RE review This PR is ready for RE review. Used in CI. label May 5, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

This PR has been labeled as ready for Release Engineering review by
@spelak-salesforce. Reviews have been requested from: @davidmreed, @sella24.

@spelak-salesforce spelak-salesforce merged commit 1dd6902 into feature/240 May 9, 2022
@spelak-salesforce spelak-salesforce deleted the feature/240__apex-code-coverage branch May 9, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for QE This item is ready for testing ready for RE review This PR is ready for RE review. Used in CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants