feat: add episode numbering option to general settings#2142
Merged
Conversation
Episode numbering previously existed only in per-podcast settings. Add an instance-wide default in general settings that is OR-ed with the per-podcast flag, mirroring how auto_download layers the per-podcast value over the global default. Enabling it in general settings turns episode-number title prefixing on for every podcast unless already enabled per podcast. Like other global settings, it applies going forward (new downloads / metadata insertion / rescan), not retroactively on save. Closes #2139
The reconcile_standard_user test helper assumed the reconcile migration was the newest one (split_last), so adding 2026-06-25 settings_episode_numbering after it broke `apply_through_pre_reconcile`. Locate the reconcile migration by name and apply only the migrations ordered before it, which preserves the test's intent and survives future migrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an Episode numbering toggle to the general (instance-wide) settings. Until now this option only existed in per-podcast settings.
Closes #2139
How
The global flag is a default that is OR-ed with the per-podcast flag, mirroring how
auto_downloadalready layers the per-podcast value over the global default (podcast_settings.auto_download || settings.auto_download).download/service.rs::episode_numbering_enabled, delegating to a pure, unit-testednumbering_from(per_podcast, global)helper that replaces the two previously-duplicated inline blocks (ID3 + MP4 metadata paths).Changes
episode_numbering BOOLEAN NOT NULL DEFAULT FALSEto thesettingstable (sqlite + postgres, withdown).Setting, persistence (table!+SettingEntity+ conversions +insert_default_settings), and the web DTO (#[serde(default)]for backward compatibility).schema.d.tsupdated (field rendered optional to match the#[serde(default)]generator output);en+detranslations added (other locales fall back to English).Behavior note
Like other global settings, the flag applies going forward (new downloads / metadata insertion / rescan), not retroactively on save.
Verification
cargo clippy --no-default-features --features sqlite --all-targets -- -D warnings✅tsc --noEmitfor the UI ✅