test(e2e): cover settings, theming, i18n, playlists and core feature pages - #2184
Merged
Conversation
…pages Adds settings.spec.ts (retention persistence, naming page, OPML export download, theme selection incl. reload persistence, language switching, notifications popover) and features.spec.ts (podcast favoriting via the favorites page, timeline filter, episodes archive, statistics, inbox, the three-step playlist wizard and the user menu). Also fixes a real playlist-wizard bug the new test uncovered: React reused the footer button's DOM node when the wizard advanced to the review step, so the browser still ran the click's default action on what had just become a type=submit button — submitting the form and skipping the review step entirely. Distinct keys per button fix it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2181 — this commit was pushed to the feature branch a few minutes after the squash-merge and didn't make it into main.
type=submitbutton — submitting the form and skipping the review step entirely. Distinctkeys per button fix it; the new wizard test guards it.Test plan
🤖 Generated with Claude Code