test(e2e): cover the untested UI routes - #2191
Merged
Merged
Conversation
…iscover, profile and admin pages Adds a pages.spec suite exercising the routes the existing e2e specs did not touch. The e2e server runs without auth, which provisions a standard admin user, so the admin-only pages render real content.
Adds settings-coverage.spec: label + toggle-persistence coverage for the Data Retention page, the Naming page, the rescan tab and the per-podcast settings modal (settings + batch-actions tabs). While covering labels, found that the nfo-format and cover-filename i18n keys were missing, so the UI rendered raw kebab keys as labels; added the English strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands e2e coverage of the UI.
pages.spec.ts— routes the existing specs didn't touch: home dashboard, waiting list, settings→rescan (runs a rescan + asserts the toast), tags (create+delete), gpodder, mopidy, discover, profile, and administration users/invites.settings-coverage.spec.ts— exhaustive label + toggle coverage:Bug fix found while covering labels: the
nfo-formatandcover-filenamei18n keys were missing fromen.json, so both the Data Retention page and the per-podcast modal rendered the raw kebab keys as labels. Added the English strings ("NFO format", "Cover filename").The e2e server runs without auth, which provisions a standard admin user, so the admin-only pages render real content. All tests pass locally.