test(e2e): make the podfetch launcher work on Windows/Git Bash - #2194
Merged
Conversation
diesel's multi-connection URL parser rejects the sqlite://<abs-path> form for Windows-style paths, so the e2e server panicked on startup under Git Bash/MSYS. Use a bare relative DATABASE_URL there (we already cd into RUN_DIR); Linux/macOS keep the sqlite:// scheme form, so CI is unaffected.
SamTV12345
enabled auto-merge (squash)
July 23, 2026 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Playwright e2e launcher hard-coded
DATABASE_URL="sqlite://$RUN_DIR/podcast.db". diesel's multi-connection URL parser rejects thatsqlite://<abs-path>form for Windows-style paths (the drive letter trips it up), so the server panicked on startup and the whole suite was unrunnable under Git Bash/MSYS.Detect the shell OS and use a bare relative
DATABASE_URLon Windows (the script alreadycds intoRUN_DIR); Linux/macOS keep the originalsqlite://scheme form, so CI behavior is byte-identical. Verified locally: the suite now boots and runs on Windows without any manual patching.