Skip to content

Support overriding default values for method parameters#586

Open
ds5678 wants to merge 1 commit into
SamboyCoding:developmentfrom
AssetRipper:override-parameter-default-value
Open

Support overriding default values for method parameters#586
ds5678 wants to merge 1 commit into
SamboyCoding:developmentfrom
AssetRipper:override-parameter-default-value

Conversation

@ds5678

@ds5678 ds5678 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

This also includes:

  • Improvements related to field constant values
  • Fixes for Diffable C# and stable renaming
  • A bump to C# 14 (necessary to use the field keyword)
  • Performance boost to AsmResolverConstants

Supercedes #578

This also includes:
* Improvements related to field constant values
* Fixes for Diffable C# and stable renaming
* A bump to C# 14 (necessary to use the `field` keyword)
* Performance boost to AsmResolverConstants
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29870676038

Coverage decreased (-0.05%) to 37.721%

Details

  • Coverage decreased (-0.05%) from the base build.
  • Patch coverage: 14 uncovered changes across 6 files (28 of 42 lines covered, 66.67%).
  • 3 coverage regressions across 3 files.

Uncovered Changes

File Changed Covered %
Cpp2IL.Core/Model/Contexts/ParameterAnalysisContext.cs 12 6 50.0%
Cpp2IL.Core/Model/Contexts/ConcreteGenericParameterAnalysisContext.cs 3 0 0.0%
Cpp2IL.Core/Model/Contexts/InjectedFieldAnalysisContext.cs 5 3 60.0%
Cpp2IL.Core/Model/Contexts/ConcreteGenericFieldAnalysisContext.cs 1 0 0.0%
Cpp2IL.Core/Model/Contexts/InjectedParameterAnalysisContext.cs 3 2 66.67%
Cpp2IL.Core/ProcessingLayers/StableRenamingProcessingLayer.cs 1 0 0.0%
Total (10 files) 42 28 66.67%

Coverage Regressions

3 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
Cpp2IL.Core/Model/Contexts/ConcreteGenericParameterAnalysisContext.cs 1 28.57%
Cpp2IL.Core/Model/Contexts/FieldAnalysisContext.cs 1 50.54%
Cpp2IL.Core/Model/Contexts/InjectedParameterAnalysisContext.cs 1 69.23%

Coverage Stats

Coverage Status
Relevant Lines: 13138
Covered Lines: 5311
Line Coverage: 40.42%
Relevant Branches: 8648
Covered Branches: 2907
Branch Coverage: 33.61%
Branches in Coverage %: Yes
Coverage Strength: 175503.5 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants