spec: add parameter postfixes#43
Merged
Bilchreis merged 4 commits intoSampleEnvironment:masterfrom Mar 2, 2026
Merged
Conversation
added 2 commits
January 13, 2026 16:10
- restricted limits to scalar numeric types - consolidated explanation to avoid repetition
Contributor
|
My opinion: |
Member
|
I agree with Markus' opinion. |
birkenfeld
reviewed
Jan 29, 2026
added 2 commits
January 29, 2026 14:25
- fixed typo in issue reference - added entry in changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions
Remark
_limitspostfix is kept (i.e.,target_limitsremains valid, and_limitsis treated as an allowed postfix /target_limitsas a special case for backwards compatibility).Open questions
(These may have been discussed already, but I couldn’t find/remember the answers in the minutes.)
In an older meeting it was agreed to omit the
_limitspostfix. See minutes (09/2023): https://github.com/SampleEnvironment/SECoP/blob/master/minutes/2023-09-26_vidconf.rst#4d-issue-77-predefined-parameter-name-postfixesThe spec currently defines a specific
target_limitsparameter, but there is no correspondingHasLimitsfeature.Should we deprecate
target_limitsand only allow the_minand_maxpostfixes?Alternatively, should we introduce an additional
_limitspostfix and treattarget_limitsas a special case?Do we allow postfixes only for predefined parameters, or also for custom parameters (those with a leading
_)?