Use a read-only deploy key for private extension builds - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
GLOSS_EXTENSION_SSH_KEYin release preflightSunChJ/personal-immersive-translatorthrough strict SSH with credentials not persistedWhy
The browser-extension source only needs read access to one private repository. A repository-scoped, read-only deploy key provides that access without creating another user PAT or granting access to the public distribution repositories.
Impact
After this change, the Gloss release only needs one user-created fine-grained PAT:
GLOSS_DISTRIBUTION_TOKENfor publishing togloss-releasesand dispatching the Homebrew tap workflow.Validation
bash -n Scripts/*.shswift test— 171 passed, 4 explicitly skipped integration testsgit diff --check