[circle-mlir] Revise README with how-to build#14843
Merged
seanshpark merged 1 commit intoSamsung:masterfrom Mar 13, 2025
Merged
[circle-mlir] Revise README with how-to build#14843seanshpark merged 1 commit intoSamsung:masterfrom
seanshpark merged 1 commit intoSamsung:masterfrom
Conversation
This will revise README file with how-to build the project. ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
Contributor
Author
shs-park
approved these changes
Mar 13, 2025
Contributor
shs-park
left a comment
shs-park
left a comment
There was a problem hiding this comment.
I have suggested some refinements to make the sentence sound a little bit natural.
Applying them is optional, so please take them as a reference.
LGTM!
=)
|
|
||
| Circle MLIR dialect and tools | ||
|
|
||
| ## Tools provided |
Contributor
There was a problem hiding this comment.
Suggested change
| ## Tools provided | |
| ## Provided Tools |
| ## Tools provided | ||
|
|
||
| _onnx2circle_ | ||
| - conversion tool of ONNX to Circle model for `compiler` |
Contributor
There was a problem hiding this comment.
Suggested change
| - conversion tool of ONNX to Circle model for `compiler` | |
| - a tool that converts ONNX models to Circle format, used by `compiler`. |
| - download and install latest `ONE Release` from https://github.com/Samsung/ONE/releases | ||
| - actually we only need `circle-interperter` tool for validation, but not ready yet | ||
|
|
||
| Or use local build/install version of `ONE/compiler` and set environment variable; |
Contributor
There was a problem hiding this comment.
Suggested change
| Or use local build/install version of `ONE/compiler` and set environment variable; | |
| Alternatively, if you have a locally built version of `ONE/compiler`, set the environment variable as follows; |
| make prep | ||
| ``` | ||
|
|
||
| NOTE `llvm-project` is built as `Debug` which may require 32G or more RAM. |
Contributor
There was a problem hiding this comment.
Suggested change
| NOTE `llvm-project` is built as `Debug` which may require 32G or more RAM. | |
| NOTE `llvm-project` builds in `Debug` mode, which may require 32GB or more RAM. |
Comment on lines
+55
to
+56
| - if build fails for some reason, please change to `-DCMAKE_BUILD_TYPE=Release` | ||
| `prep` target in `Makefile.sample` file. |
Contributor
There was a problem hiding this comment.
Suggested change
| - if build fails for some reason, please change to `-DCMAKE_BUILD_TYPE=Release` | |
| `prep` target in `Makefile.sample` file. | |
| - if the build fails, try changing the build type to `-DCMAKE_BUILD_TYPE=Release` | |
| in the `prep` target of `Makefile.sample` file. |
Contributor
Author
|
@shs-park , thanks for the suggestion! |
Contributor
Sure, no problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will revise README file with how-to build the project.