Skip to content

[circle-mlir] Revise README.md#14846

Merged
seanshpark merged 2 commits intoSamsung:masterfrom
shs-park:circle-mlir/revise-readme
Mar 14, 2025
Merged

[circle-mlir] Revise README.md#14846
seanshpark merged 2 commits intoSamsung:masterfrom
shs-park:circle-mlir/revise-readme

Conversation

@shs-park
Copy link
Copy Markdown
Contributor

In this PR, some refinements will be suggested to make the sentence sound a little bit natural.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park shs.park@samsung.com


In this PR, some refinements will be suggested to make the sentence
sound a little bit natural.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
@shs-park shs-park self-assigned this Mar 13, 2025
@shs-park shs-park requested a review from a team March 13, 2025 14:48
Comment thread circle-mlir/README.md Outdated
- actually we only need `circle-interperter` tool for validation, but not ready yet

Or use local build/install version of `ONE/compiler` and set environment variable;
Alternatively, if you have a locally built version of `ONE/compiler`,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiler and ONE/compiler is the same one and as this is the ONE repo,
I think we can omit ONE :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have uploaded a commit reflecting the change
=)

Remove unnecessary occurrences of "ONE" in terms referring to the compiler.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
@shs-park shs-park requested a review from seanshpark March 14, 2025 00:19
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@seanshpark seanshpark merged commit 3818a6e into Samsung:master Mar 14, 2025
5 checks passed
@shs-park shs-park deleted the circle-mlir/revise-readme branch March 24, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants