[evaluation] Generation mode and videomme benchmark support for Gemma4 - #865
Merged
Conversation
Torrero
force-pushed
the
gemma_eval_videomme
branch
from
August 5, 2026 15:07
742ab0f to
b0978a4
Compare
This commit supports generation mode and videomme benchmark for Gemma4 Co-Authored-By: Cline TICO-DCO-1.0-Signed-off-by: Evgenii Maltsev <e.maltsev@samsung.com>
Torrero
force-pushed
the
gemma_eval_videomme
branch
from
August 5, 2026 15:29
b0978a4 to
26b6430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds generation support and Video-MME benchmark support to the Gemma4 PTQ wrappers:
Generation support —
QuantGemma4ForCausalLMandQuantGemma4ForConditionalGenerationnow inherit fromGenerationMixinand implement all the methods HF'sgenerate().Video-MME benchmark support — The Gemma4 adapter's
evaluate()method now supportvideommebenchmark.For gemma4 evaluation with max_position_embeddings=2048 we should use
max_num_frames= 21 unlike qwen3-vl wheremax_num_frames=35 is used.In Gemma4, the minimum limit of soft_tokens_per_frame=70 (comes from processor.video_processor.max_soft_tokens) when for qwen3-vl we can control the minimum tokens per frame.
Co-Authored-By: Cline
TICO-DCO-1.0-Signed-off-by: Evgenii Maltsev e.maltsev@samsung.com