fix: root release evidence paths - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The release workflow configured relative report paths such as
artifacts/rollback-drill.json, but Go tests execute withinternal/storageas their working directory. The report was therefore writtenunder the package directory while
actions/upload-artifactsearched from therepository root. The rollback test passed, but the required release evidence
was not uploaded and the final release job could not consume it.
Fix
Normalize relative CAS stress and rollback report paths against the repository
root in
scripts/postgres_cas_gate.sh. Absolute paths remain unchanged.Validation
bash -n scripts/postgres_cas_gate.shgit diff --checkGRAPHDB_TEST_ROLLBACK_REPORT=artifacts/rollback-fix-smoke.jsonartifacts/and does not existunder
internal/storage/artifacts/6a741677f5d0e8f35ebc8fb3fe6cb00872686f60matches the locally validatedscript exactly