Skip to content

🔒 Fix race condition in SlidingWindow rate limiter - #50

Merged
Sanan507 merged 2 commits into
masterfrom
sentinel-rate-limit-race-condition-6945787369349799329
Aug 1, 2026
Merged

🔒 Fix race condition in SlidingWindow rate limiter#50
Sanan507 merged 2 commits into
masterfrom
sentinel-rate-limit-race-condition-6945787369349799329

Conversation

@Sanan507

@Sanan507 Sanan507 commented Aug 1, 2026

Copy link
Copy Markdown
Owner

🎯 What: Fixed a race condition vulnerability in the SlidingWindow class's tryAcquire method within RateLimitFilter.java. The timestamps.size() >= limit check and the subsequent timestamps.addLast(now) operation were not executed atomically, allowing concurrent requests to bypass the limit.

⚠️ Risk: Under high concurrency (e.g., in a coordinated attack), multiple threads could simultaneously evaluate the size check as true before any of them added their timestamp to the deque. This would allow an attacker to exceed the rate limits configured to protect computationally expensive simulation endpoints from DoS attacks.

🛡️ Solution: Added the synchronized keyword to the tryAcquire method signature. This ensures that the entire process of evicting old timestamps, checking the current count, and adding the new timestamp is performed atomically per SlidingWindow instance, enforcing the rate limit correctly even under concurrent load.


PR created automatically by Jules for task 6945787369349799329 started by @Sanan507

Co-authored-by: Sanan507 <227714367+Sanan507@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
algorithm-race-visualizer Ready Ready Preview Aug 1, 2026 8:45am

@Sanan507
Sanan507 merged commit 0ca4f26 into master Aug 1, 2026
4 checks passed
@Sanan507
Sanan507 deleted the sentinel-rate-limit-race-condition-6945787369349799329 branch August 1, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant