🔒 Fix race condition in SlidingWindow rate limiter - #50
Conversation
Co-authored-by: Sanan507 <227714367+Sanan507@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎯 What: Fixed a race condition vulnerability in the
SlidingWindowclass'stryAcquiremethod withinRateLimitFilter.java. Thetimestamps.size() >= limitcheck and the subsequenttimestamps.addLast(now)operation were not executed atomically, allowing concurrent requests to bypass the limit.🛡️ Solution: Added the
synchronizedkeyword to thetryAcquiremethod signature. This ensures that the entire process of evicting old timestamps, checking the current count, and adding the new timestamp is performed atomically perSlidingWindowinstance, enforcing the rate limit correctly even under concurrent load.PR created automatically by Jules for task 6945787369349799329 started by @Sanan507