Skip to content

Unblock backend CI by fixing Spotless violations and Pathfinding request arity #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sanan507 merged 3 commits into from
Aug 3, 2026
Merged

Unblock backend CI by fixing Spotless violations and Pathfinding request arity #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
923b828
Initial plan
Copilot Aug 3, 2026
e035f41
fix: apply backend spotless formatting required by CI
Copilot Aug 3, 2026
33ff37c
test: fix pathfinding request constructor args in backend tests
Copilot Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions backend/src/main/java/com/algorithmrace/visualizer/service/SimulationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,7 @@ public RaceResponse simulatePathfinding(PathfindingSimulationRequest request) {
weights = sanitizeWeights(request.weights(), rows, cols);
} else {
weights =
MazeGenerator.generateWeights(
rows, cols, MazeGenerator.fromName(request.mazeType()));
MazeGenerator.generateWeights(rows, cols, MazeGenerator.fromName(request.mazeType()));
}

List<String> algos = sanitizeAlgorithms(request.algorithms());
Expand Down
3 changes: 2 additions & 1 deletion backend/src/main/java/com/algorithmrace/visualizer/utils/MazeGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ public static boolean[][] generate(
case PRIM -> prims(rows, cols);
case RECURSIVE_DIVISION -> recursiveDivision(rows, cols);
case CELLULAR_AUTOMATA -> cellularAutomata(rows, cols);
case WEIGHTED_TERRAIN_MAP -> new boolean[rows][cols]; // Terrain maps rely on weights, not walls
case WEIGHTED_TERRAIN_MAP ->
new boolean[rows][cols]; // Terrain maps rely on weights, not walls
};
clearArea(walls, startRow, startCol, rows, cols);
clearArea(walls, endRow, endCol, rows, cols);
Expand Down
2 changes: 1 addition & 1 deletion ...t/java/com/algorithmrace/visualizer/algorithms/pathfinding/PathfindingAlgorithmsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ void testPathfindingBlockedEndNode() {
void testSimulationServicePathfinding() {
PathfindingSimulationRequest request =
new PathfindingSimulationRequest(
algorithms, 10, 10, "Clear Grid", null, null, null, null, null);
algorithms, 10, 10, "Clear Grid", null, null, null, null, null, null);

RaceResponse response = simulationService.simulatePathfinding(request);

Expand Down
6 changes: 4 additions & 2 deletions backend/src/test/java/com/algorithmrace/visualizer/controller/SimulationControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ void searching_outOfBoundsSize_badRequest() throws Exception {
@Test
void pathfinding_validRequest_success() throws Exception {
PathfindingSimulationRequest request =
new PathfindingSimulationRequest(List.of("BFS"), 20, 20, "Clear Grid", null, null, 0, 0, 19, 19);
new PathfindingSimulationRequest(
List.of("BFS"), 20, 20, "Clear Grid", null, null, 0, 0, 19, 19);

RaceResponse response =
new RaceResponse("pathfinding", null, null, null, null, new ArrayList<>(), null);
Expand Down Expand Up @@ -158,7 +159,8 @@ void pathfinding_emptyAlgorithms_badRequest() throws Exception {
@Test
void pathfinding_outOfBoundsDimensions_badRequest() throws Exception {
PathfindingSimulationRequest request =
new PathfindingSimulationRequest(List.of("BFS"), 7, 20, "Clear Grid", null, null, 0, 0, 6, 19);
new PathfindingSimulationRequest(
List.of("BFS"), 7, 20, "Clear Grid", null, null, 0, 0, 6, 19);

mockMvc
.perform(
Expand Down
Loading