Question: Is upgrading of settings.xml to version 1 format on the todo list?

[andrewbird]

Hi, thanks for the wonderful add-in!

I was looking at adding a backwardly compatible colour picker for the prime / pay colours and started to experiment a little. Firstly I understand that kodi is quite forgiving regarding xml tags it doesn't understand so using the kodi 20+ colorbutton should just allow silent fallback to string setting as now. So I tried this out, and it seems I need to convert the settings.xml file to format to version 1 (apparently that's also valid in kodi 19).

Questions.

1. Is an upgrade to version 1 settings format something acceptable?
2. If so, the existing makes heavy use of relative offsets for determining the visibility of the control, is that something we could rationalise?
3. If so, what is the primary intent of those visibility tags?
4. The setting with id="browser" has a static label 'Browser', shouldn't this be a numeric?
5. In general settings the browser choice appears in 'Browser' mode and 'Script/Batch', is the second correct? (NEW)

Thanks!

[andrewbird]

this is what I ended up with for pay/prime colour controls

        <setting id="paycont" type="boolean" label="30073" visible="true">
          <control type="toggle" />
          <default>false</default>
        </setting>
        <setting id="paycol" type="string" label="30292" subsetting="true">
          <control type="colorbutton" />
          <default>FFE95E01</default>
          <dependencies>
            <dependency type="visible" setting="paycont">true</dependency>
          </dependencies>
        </setting>
        <setting id="primecol" type="string" label="30293" subsetting="true">
          <control type="colorbutton" />
          <default>FF00A8E0</default>
          <dependencies>
            <dependency type="enable" setting="paycont">true</dependency>
          </dependencies>
        </setting>

Note the experiment with enable/visible.

[Sandmann79]

Hi the migration is done via above commit.

With the new settings format, the offset entries have been replaced by the parent keyword, which makes things a bit clearer now.
Yes, the Browser choice should be appear in both categories.

[andrewbird]

Hi the migration is done via above commit.

Hi thanks for doing that. I wish you'd said you were going to as I've been working on it here https://github.com/andrewbird/kodi-addon-amazon/tree/settingsv1 converting and adding all the translations strings etc. Anyway I hadn't quite finished, so at least there's that 😄