Skip to content

Conversation

@SapientGuardian
Copy link
Owner

This MR restores functionality of the Keywords resource.

… transactions (and probably many other things)
@SapientGuardian
Copy link
Owner Author

@IntelOrca your sample repro no longer crashes with this version. Do you have a larger context you can test this in, or is that yet to be written?

@IntelOrca
Copy link

I do, but I won't be able to test that until tomorrow evening. Would it be okay for you to tag another build with this fix?

@SapientGuardian
Copy link
Owner Author

Will do. Even if this doesn't fix your scenario, I suspect there are others that will be helped by this.

@SapientGuardian SapientGuardian merged commit 15e89c6 into 6.9_netstandard May 25, 2016
@SapientGuardian SapientGuardian deleted the FixKeywords branch May 25, 2016 00:27
@IntelOrca
Copy link

With the test project from #10 I now get

Unhandled Exception: System.ArgumentNullException: Value cannot be null.
Parameter name: stream
   at System.IO.StreamReader..ctor(Stream stream, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize, Boolean leaveOpen)
   at MySql.Data.MySqlClient.Properties.Resources.LoadKeywords()
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at MySql.Data.MySqlClient.MySqlCommand.AddCallStatement(String query)
   at MySql.Data.MySqlClient.MySqlCommand.ExecuteReader(CommandBehavior behavior)
   at MySql.Data.MySqlClient.MySqlCommand.ExecuteNonQuery()
   at MySql.Data.MySqlClient.MySqlConnection.BeginTransaction(IsolationLevel iso)
   at ConsoleApplication.Program.Main(String[] args)

I will investigate...

@IntelOrca
Copy link

https://github.com/SapientGuardian/mysql-connector-net-netstandard/blob/6.9_netstandard/Source/MySql.Data/Properties/Resources.Designer.cs#L630

This might need to be changed to SapientGuardian.MySql.Data.Properties.keywords.txt

@SapientGuardian
Copy link
Owner Author

Well that's annoying. Fixing...

@SapientGuardian
Copy link
Owner Author

Fixed in SapientGuardian.MySql.Data 6.9.8-rc2-006

@IntelOrca
Copy link

thanks, it works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants