[codex] Fix oversample repack and transfer regressions - #116
Merged
Conversation
…et LOD meshes are included. Update documentation to reflect this change and add tests for target detection logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internalOversample > 1, while keeping the existing cost budget for 1x packs.MeshEntryintoGroupedShellTransfer, then scale UV2 margins in pixel terms instead of fixed normalized-space constants.EXPERIMENTS.mdwith the follow-up findings and add EditMode regression tests for both fixes.AnalyzeMeshcall and tuple field references inUvShellExtractorTests.Root Cause
internalOversample = 4raised the internal xatlas search area from 256x256 to roughly 1024x1024, but the brute-force preflight still allowed the Carousel-sized case because it stayed below the old 500M operation budget. Separately, transfer used normalized UV2 tolerances like0.005and0.01; after xatlas grew resolved atlases past 1k, those constants represented many more pixels than before and could mask extrapolation into neighboring packed regions.Validation
git diff --cached --checkfile:path:9/9 passedNotes
The repository checkout does not include the Carousel / Playground / WateringCan FBX suite or prior
BenchmarkReports, so model-levelrepackMs, density spread, and overlap metrics still need to be captured manually in Unity against the benchmark suite.