Skip to content

Защита CSV от формул в экспорте метрик FBX - #159

Closed
SashaRX wants to merge 1 commit into
mainfrom
codex/fix-csv-formula-injection-vulnerability
Closed

Защита CSV от формул в экспорте метрик FBX#159
SashaRX wants to merge 1 commit into
mainfrom
codex/fix-csv-formula-injection-vulnerability

Conversation

@SashaRX

@SashaRX SashaRX commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Исправить уязвимость CSV formula injection: имена моделей, LODGroup и renderer могли начинаться с =, +, -, @ и при открытии в таблицах интерпретироваться как формулы.

Description

  • Добавлена нейтрализация префиксов в Csv(string): если строка начинается с =, +, - или @, к ней добавляется ведущий апостроф, при этом сохранено текущее экранирование запятых/кавычек/переводов строки.
  • Добавлен регрессионный NUnit-тест Tests/Editor/FbxMetricsExporterTests.cs, проверяющий нейтрализацию опасных префиксов и взаимодействие с существующим CSV-экранированием.

Testing

  • Прогнаны статические проверки и вспомогательные скрипты: git diff --check, валидация package.json, проверка формата версии и присутствие соответствующих .meta для тестовых файлов — все прошли успешно.
  • Новые NUnit EditMode-тесты добавлены в репозиторий, но EditMode-тесты Unity не были выполнены в CI контейнере, так как в среде отсутствует исполняемый файл Unity; это не мешает проверке регрессии на машине с Unity.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8e987987-5c02-4d4b-9454-87ad08f5dea8

📥 Commits

Reviewing files that changed from the base of the PR and between 21d382e and 7230b00.

📒 Files selected for processing (3)
  • Editor/FbxMetricsExporter.cs
  • Tests/Editor/FbxMetricsExporterTests.cs
  • Tests/Editor/FbxMetricsExporterTests.cs.meta

Comment @coderabbitai help to get the list of available commands.

SashaRX commented Aug 6, 2026

Copy link
Copy Markdown
Owner Author

Фикс вошёл в консолидированную ветку claude/security-pr-analysis-fmpzf0 коммитом 0e50071, затем объединено в общий CsvUtil (8892f9a). Закрыт как superseded.


Generated by Claude Code

@SashaRX SashaRX closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant