Добавить флаг symmetry-split в sidecar и учитывать его в deterministic replay - #17
Merged
SashaRX merged 1 commit intoMar 3, 2026
Conversation
SashaRX
pushed a commit
that referenced
this pull request
Mar 3, 2026
…et mode Resolved conflicts with PR #17 in ExecSymmetrySplit(): - Combined LOD filtering (source-only default) with wasSymmetrySplit tracking - Method accepts bool includeTargets AND sets e.wasSymmetrySplit flag https://claude.ai/code/session_01198JqNgkdbzwRFc7nt8FqJ
SashaRX
pushed a commit
that referenced
this pull request
Mar 3, 2026
…urce-only split) Merged PRs: - #18 codex/update-shell-computation-logic (majority vote) - #17 codex/add-symmetry-split-support-to-sidecar-metadata (sidecar flag) - #16 codex/refactor-execsymmetrysplit-to-handle-source-lod (source-only default) Resolved merge conflict between PR #17 and #16 in ExecSymmetrySplit(): combined LOD filtering with wasSymmetrySplit tracking. Removed REVIEW.md (deleted by all 3 PRs). https://claude.ai/code/session_01198JqNgkdbzwRFc7nt8FqJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
wasSymmetrySplitвMeshEntryи полеsymmetrySplit/stepSymmetrySplitвSidecarEntry/MeshUv2Entryи прокинуто вUv2DataAsset.Set(...)для сохранения в sidecar.ExecSymmetrySplit()теперь помечаетсяwasSymmetrySplitдля меша и приApplyUv2ToFbx()генерация/сохранение replay-данных (vertexRemap,optimizedVertexCount,optimizedTriangles,submeshTriangleCounts) выполняется также когда была применена symmetry split.ResolveSymmetrySplitStep(...), детерминированный путь логирует наличиеsymmetrySplit, и предупреждения/fallback теперь учитывают symmetry split как топологически изменяющий шаг.Uv2DataAssetschema/tool версии (CurrentSchemaVersion = 2,ToolVersionStr = "0.13.0") и добавлена логика backwards-compatible (эвристика для старых sidecar с replay-данными, но без явного флага).ResetWorkingCopies()очищаетwasSymmetrySplit, и логи[Apply]/[UV2 Postprocess]теперь явно показывают, что replay включает symmetry split.Testing
git diff --checkзавершился без ошибок.git status --shortиgit show --stat --oneline HEAD, оба показали ожидаемые изменения и успешный коммит.Add symmetry split flag to sidecar replay path) и PR-сообщение сформировано; никаких автоматических юнит-тестов в кодовой базе не запускалось в рамках этого изменения.Codex Task