Conversation
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
There was a problem hiding this comment.
Pull request overview
Adds an initial JSON Schema entry for prek configuration files and registers it in the SchemaStore catalog.
Changes:
- Added a
prek.tomltest fixture. - Added a new (currently minimal) JSON Schema for
prek. - Registered
prekincatalog.jsonforprek.tomlfile matching.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/test/prek/prek.toml | Adds a sample prek configuration used for validation/testing. |
| src/schemas/json/prek.json | Introduces the JSON Schema definition for prek. |
| src/api/json/catalog.json | Registers the prek schema in the public catalog. |
7cec49b to
dd8ac70
Compare
| "name": "prek", | ||
| "description": "Configuration file for prek, a tool for managing git hooks", | ||
| "fileMatch": ["prek.toml"], | ||
| "url": "https://www.schemastore.org/prek.json" |
There was a problem hiding this comment.
Just some reminder, we can just add a schema file link here, not total schema file, if schema file changed in the future, we need to make a PR again and wait review again, that may take a long time. Like I do in #5170.
There was a problem hiding this comment.
Thanks! I saw that rumdl switched from an external hosting schema to a locally hosted one in #5305. Hosting it externally means you don’t have to open PRs every time you update it, but having a link like "https://www.schemastore.org/prek.json" is way more convenient than something like "https://raw.githubusercontent.com/j178/prek/master/prek.schema.json", and it also feels more trustworthy for users.
for more information, see https://pre-commit.ci
|
Thanks! This ready to merge? |
|
Yes! |
|
Great, thanks |
|
Thank you❤️ |
prek is a git hook manager written in Rust. This PR adds JSON Schema for configuration file:
prek.toml.Related Links:
Project repository: https://github.com/j178/prek
Schema file: https://raw.githubusercontent.com/j178/prek/master/prek.schema.json