Redis key layout fixture as the SDK contract - #126
Merged
Conversation
The C# and Ruby SDKs doubled the schematic: prefix for over a year without a test on either side noticing (SCH-7070). Put the key layout in a fixture the replicator tests against and the SDK unit tests copy, and document the layout in the README.
This was referenced Sep 6, 2026
bpapillon
marked this pull request as ready for review
September 6, 2026 05:01
schematic-bot
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C# and Ruby SDKs doubled the
schematic:prefix on every replicator lookup (SCH-7070); nothing on either side tested the key layout as a contract.testdata/redis_key_layout.json: the keys the replicator writes, with<VERSION>for the rules engine cache version.TestRedisKeyLayoutMatchesFixture: the builders incache.gomust produce exactly those keys.SDK repos copy the fixture into their unit tests (Node and Python PRs alongside; Go, Java, Ruby and C# already assert their layouts after #182/#53).