Conversation
Re-use PartialCompany/PartialUser from schematic-go/datastream On cache miss for partial messages, log a warning and skip rather than writing incomplete data. Remove dead pre-merge unmarshal code. Update go.mod to schematic-go@f539b4e (main HEAD). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dontlaugh
changed the title
dontlaugh
marked this pull request as ready for review
March 16, 2026 18:03
dontlaugh
commented
Mar 16, 2026
| github.com/schematichq/rulesengine v0.1.14 | ||
| github.com/schematichq/schematic-datastream-ws v0.2.7 | ||
| github.com/schematichq/schematic-go v1.4.3 | ||
| github.com/schematichq/schematic-go v1.4.4-0.20260316174403-f539b4e4a607 |
Contributor
Author
There was a problem hiding this comment.
An unreleased version we can use if we want.
bpapillon
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-use PartialCompany/PartialUser from schematic-go/datastream
On cache miss for partial messages, log a warning
and skip rather than writing incomplete data. Remove dead pre-merge
unmarshal code. Update go.mod to schematic-go@f539b4e (main HEAD).