Float the Consent Action and Rebuild the Documentation Grid - #90
Float the Consent Action and Rebuild the Documentation Grid#90PSchmiedmayer wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
OnboardingConsentView.confirm(scrollingWith:) can currently call the continuation action() when consentDocument is nil, which risks advancing the flow unexpectedly in edge cases.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the consent onboarding experience so the primary “I Consent” action remains reachable while scrolling, and refreshes the DocC/README documentation grids and screenshots to match the intended module flow.
Changes:
- Reworks
OnboardingConsentViewto use aPageView+ floating footer action that can scroll to the first incomplete element and provide haptic/a11y feedback. - Adds/updates UI-test-driven documentation screenshot flows for GroveConsent and adjusts the TestApp presentation to better match real app fullscreen flow.
- Reorders and refreshes documentation/README image grids, and removes now-unneeded per-image
.licensesidecars for DocC resources.
File summaries
| File | Description |
|---|---|
| Tests/GroveConsentTests/UITests/TestAppUITests/DocumentationScreenshots.swift | Adds the GroveConsent documentation screenshot capture flow and markers for the screenshot script. |
| Tests/GroveConsentTests/UITests/TestApp/ContentView.swift | Presents the screenshot flow fullscreen (non-macOS) to match real app presentation for documentation captures. |
| Tests/GroveConsentTests/UITests/TestApp/Consent/ScreenshotView.swift | Updates consent screenshot copy and the displayed title to “Study Consent”. |
| Sources/GroveLLMLocal/GroveLLMLocal.docc/Resources/ChatView~dark.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/GroveLLMLocal/GroveLLMLocal.docc/Resources/ChatView.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/GroveContact/GroveContact.docc/Resources/Overview~dark.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/GroveContact/GroveContact.docc/Resources/Overview.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/GroveConsent/Views/OnboardingConsentView.swift | Implements floating consent action button with scroll-to-incomplete + a11y/haptic feedback behavior. |
| Sources/GroveConsent/GroveConsent.docc/GroveConsent.md | Updates the consent documentation grid to the new screenshot set and adds an “incomplete form” example. |
| Sources/Grove/Grove.docc/Resources/Validation.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/Grove/Grove.docc/Resources/QuestionnaireOverview.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/Grove/Grove.docc/Resources/PairedDevices.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/Grove/Grove.docc/Resources/Consent1.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/Grove/Grove.docc/Resources/ChatView.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/Grove/Grove.docc/Resources/AccountSetup.png.license | Removes DocC resource sidecar license file (DocC resources covered by REUSE annotations). |
| Sources/Grove/Grove.docc/Grove.md | Rebuilds/reorders the umbrella documentation grid to match the participant’s module flow. |
| README.md | Rebuilds/reorders the README module screenshot table and updates the supporting text. |
Review details
- Files reviewed: 17/55 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
a8fc62a to
ef1ad92
Compare
ef1ad92 to
95f253a
Compare
95f253a to
a0b5d77
Compare
769dabc to
cecad51
Compare
cecad51 to
2d6f722
Compare
0877e69 to
f39bea2
Compare
f39bea2 to
f8a5cb8
Compare
f8a5cb8 to
e07bf4e
Compare
e07bf4e to
68c64ab
Compare
68c64ab to
0bd1a47
Compare
0bd1a47 to
0bb61df
Compare
0bb61df to
ff21ca1
Compare
♻️ Current situation & Problem
"I Consent" ended the consent page instead of staying in reach, and the umbrella page and README mixed a bare chart snapshot into a grid of framed screenshots, in no particular order.
⚙️ Release Notes
BlockingMessagefrom Share One Page Scaffold and Blocking Feedback Across the Views #87; the eraser on the signature is tappable again on iOS 26.📚 Documentation
The consent page shows a longer document read to its end and signed, the interactive elements, and an incomplete form.
✅ Testing
The consent UI suite and unit legs on iOS, the macOS unit leg, the documentation build and the link check.
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: