Use Kokkos Parallelization in Interpolation::Injection

[julianlitz]

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

• There is at least one issue associated with the pull request.
• New code adheres with the coding guidelines
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

• Tests for new functionality has been added
• A local test was succesful

If new functionality was added:

• There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

• Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

• Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

• Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
• The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
• There are appropriate unit tests and they pass.
• The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
• Coverage report for new code is acceptable.
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

[julianlitz]

@EmilyBourne
I tried to supply Kokkos::iteate::Left and Kokkos::iteate::Rigt in the hope it would switch the inner and outer loop order, but it had no effect.
So for the radial loop, I now swapped the bounds.
But its a bit ugly and can lead to subtle errors if one is not carefull.

[EmilyBourne]

@EmilyBourne I tried to supply Kokkos::iteate::Left and Kokkos::iteate::Rigt in the hope it would switch the inner and outer loop order, but it had no effect. So for the radial loop, I now swapped the bounds. But its a bit ugly and can lead to subtle errors if one is not carefull.

Hmmm, I would also expect that to work. I'm not sure why swapping the bounds is more dangerous than having 2 for loops in a different order though? Have I missed something or is your only worry about the fact that the order is different between the 2 loops?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.72%. Comparing base (92d8af2) to head (c7baa46).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   90.70%   90.72%   +0.01%     
==========================================
  Files          86       86              
  Lines        9458     9473      +15     
==========================================
+ Hits         8579     8594      +15     
  Misses        879      879              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[julianlitz]

Two arguments are needed here: MDRangePolicy<Rank<2, Iterate::Right, Iterate::Right>>. Thats why my try didnt work

[julianlitz]

I added some comments which seem not that usefull, but they help in control the clang formatting so it remains readable.