Skip to content

Use Kokkos::Parallel in Interpolation#236

Merged
julianlitz merged 9 commits into
mainfrom
litz_004
May 6, 2026
Merged

Use Kokkos::Parallel in Interpolation#236
julianlitz merged 9 commits into
mainfrom
litz_004

Conversation

@julianlitz

Copy link
Copy Markdown
Collaborator

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@codecov

codecov Bot commented May 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.81%. Comparing base (5952563) to head (f9082eb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   90.72%   90.81%   +0.09%     
==========================================
  Files          86       86              
  Lines        9473     9573     +100     
==========================================
+ Hits         8594     8694     +100     
  Misses        879      879              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz julianlitz changed the title Use Kokkos::parallel_for in Interpolation Use Kokkos::Parallel in Interpolation May 1, 2026
Comment thread src/Interpolation/extrapolated_prolongation.cpp Outdated
@julianlitz julianlitz requested a review from EmilyBourne May 5, 2026 19:04
Comment thread src/Interpolation/injection.cpp
Comment thread src/Interpolation/injection.cpp
Comment thread src/Interpolation/prolongation.cpp
Comment thread src/Interpolation/restriction.cpp

@EmilyBourne EmilyBourne left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok for me. But I think we should pick a strategy and stick to it for loops. Your comment in #235 said that you felt that the method used in this PR could lead to subtle errors if one is not careful.

@julianlitz

Copy link
Copy Markdown
Collaborator Author

@EmilyBourne All PRs I made use the Rank<2> with manual loop swap for the radial direction. i believe thats the best approach.

@julianlitz julianlitz merged commit 364910d into main May 6, 2026
8 checks passed
@julianlitz julianlitz deleted the litz_004 branch May 6, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants