Skip to content

Ensure SparseLUSolver is usable on GPU#254

Merged
EmilyBourne merged 28 commits into
mainfrom
ebourne_sparse_lu
May 12, 2026
Merged

Ensure SparseLUSolver is usable on GPU#254
EmilyBourne merged 28 commits into
mainfrom
ebourne_sparse_lu

Conversation

@EmilyBourne

@EmilyBourne EmilyBourne commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Should be merged after #255 so code can be properly tested.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@EmilyBourne EmilyBourne marked this pull request as ready for review May 12, 2026 06:12
@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.14286% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.04%. Comparing base (fc2130f) to head (c8f9228).

Files with missing lines Patch % Lines
...de/DirectSolver/DirectSolverGive/matrixStencil.inl 62.50% 3 Missing ⚠️
...de/DirectSolver/DirectSolverTake/matrixStencil.inl 62.50% 3 Missing ⚠️
include/LinearAlgebra/Solvers/csr_lu_solver.h 99.10% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   90.04%   90.04%   -0.01%     
==========================================
  Files          79       79              
  Lines        8721     8791      +70     
==========================================
+ Hits         7853     7916      +63     
- Misses        868      875       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmilyBourne EmilyBourne marked this pull request as draft May 12, 2026 06:46
@EmilyBourne EmilyBourne marked this pull request as ready for review May 12, 2026 07:22
@EmilyBourne

Copy link
Copy Markdown
Collaborator Author

On v100 at c8f9228

100% tests passed, 0 tests failed out of 268

@EmilyBourne EmilyBourne requested a review from julianlitz May 12, 2026 08:26
@EmilyBourne EmilyBourne merged commit eb05299 into main May 12, 2026
9 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_sparse_lu branch May 12, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants