Ensure cuda-compiled code passes tests

[EmilyBourne]

Ensure Kokkos execution space matches the memory space where the data being accessed is stored. This ensures the cuda-compiled version passes the tests. Currently on main it fails because loops are on GPU but access CPU data

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

• There is at least one issue associated with the pull request.
• New code adheres with the coding guidelines
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

• Tests for new functionality has been added
• A local test was succesful

If new functionality was added:

• There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

• Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

• Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

• Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
• The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
• There are appropriate unit tests and they pass.
• The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
• Coverage report for new code is acceptable.
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (0402c30) to head (9e735a7).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   90.03%   90.04%           
=======================================
  Files          79       79           
  Lines        8713     8721    +8     
=======================================
+ Hits         7845     7853    +8     
  Misses        868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[julianlitz]

I would have thought that we dont need the 2nd Vector template since we would fix Vector to DefaultMemorySpace anyways

[EmilyBourne]

I would have thought that we dont need the 2nd Vector template since we would fix Vector to DefaultMemorySpace anyways

Eventually it would be good to switch the default. However if we want to print debugging info it is useful to be able to get a host Vector. For now the main reason for adding it is so that we can test things that are fully ported without waiting for everything to be ported (e.g. see #254)

[EmilyBourne]

I would have thought that we dont need the 2nd Vector template since we would fix Vector to DefaultMemorySpace anyways

Eventually it would be good to switch the default. However if we want to print debugging info it is useful to be able to get a host Vector. For now the main reason for adding it is so that we can test things that are fully ported without waiting for everything to be ported (e.g. see #254)

It is also necessary for testing. Google test only works on CPU so we need to be able to get a host Vector to call EXPECT_NEAR etc