-
Notifications
You must be signed in to change notification settings - Fork 19
Closed
Labels
class::improvementCleanup that doesn't affect functionalityCleanup that doesn't affect functionalitygood first issueGood for newcomersGood for newcomersloc::backendThis issue concerns the C++ backend implementation.This issue concerns the C++ backend implementation.model::abmThis issue concerns any kind of agent-based model.This issue concerns any kind of agent-based model.
Description
Motivation / Current Behaviour
We want to apply recent changes to age groups in abm_minimal.cpp to all other ABM files.
Enhancement description
The proposed changes include
- renaming age group variables to use lower-case letters, so they do not look like macros,
- changing value assignment from
AgeGroup(num_age_groups - n)to simplyAgeGroup(n).- The idea for the former was that it could help a user assigning AgeGroups values in [0, num_age_groups). This is better achieved using documentation and some asserts in the ABM code.
Additional context
No response
Checklist
- Attached labels, especially loc:: or model:: labels.
- Linked to project
Metadata
Metadata
Assignees
Labels
class::improvementCleanup that doesn't affect functionalityCleanup that doesn't affect functionalitygood first issueGood for newcomersGood for newcomersloc::backendThis issue concerns the C++ backend implementation.This issue concerns the C++ backend implementation.model::abmThis issue concerns any kind of agent-based model.This issue concerns any kind of agent-based model.
Type
Projects
Status
Done (Total) 💯