846 adjust naming and assignment of abm age groups #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 118 118
Lines 9263 9269 +6
=======================================
+ Hits 8842 8848 +6
Misses 421 421 ☔ View full report in Codecov by Sentry. |
xsaschako
deleted the
846-adjust-naming-and-assignment-of-abm-age-groups
branch
reneSchm
requested changes
Dec 20, 2023
Member
reneSchm
left a comment
reneSchm
left a comment
There was a problem hiding this comment.
The name changes are great, but the asserts need to be fixed. I added suggestions only to a few, since several are very similar.
| mio::abm::InfectionState infection_state, mio::abm::TimePoint t, | ||
| mio::abm::Parameters params) | ||
| { | ||
| assert((size_t)age.size < (size_t)params.get_num_groups()); |
Member
There was a problem hiding this comment.
Suggested change
| assert((size_t)age.size < (size_t)params.get_num_groups()); | |
| assert(age.get() < params.get_num_groups()); |
| mio::abm::Person& add_test_person(mio::abm::World& world, mio::abm::LocationId loc_id, mio::AgeGroup age, | ||
| mio::abm::InfectionState infection_state, mio::abm::TimePoint t) | ||
| { | ||
| assert((size_t)age.size < (size_t)world.parameters.get_num_groups()); |
Member
There was a problem hiding this comment.
Suggested change
| assert((size_t)age.size < (size_t)world.parameters.get_num_groups()); | |
| assert(age.get() < world.parameters.get_num_groups()); |
Member
|
I opened #873 and will merge this asap with rene |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes made, additional Information and what the Reviewer should look out for:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
closes #846