Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Dec 2, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Move tests for each pkg up
  • So, we avoid import shadowing
  • And, the tests are not installed along the regular package

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu changed the title move simulations 1440 Move directory of python packages Dec 2, 2025
@HenrZu HenrZu linked an issue Dec 2, 2025 that may be closed by this pull request
2 tasks
@HenrZu HenrZu requested a review from reneSchm December 3, 2025 08:31
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (1110-pyproject-migration@31023f0). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             1110-pyproject-migration    #1441   +/-   ##
===========================================================
  Coverage                            ?   97.24%           
===========================================================
  Files                               ?      184           
  Lines                               ?    15802           
  Branches                            ?        0           
===========================================================
  Hits                                ?    15367           
  Misses                              ?      435           
  Partials                            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to directory structure and documentation look nice. I will run another local test, and then merge this.

@reneSchm reneSchm merged commit e16e29d into 1110-pyproject-migration Dec 3, 2025
57 checks passed
@reneSchm reneSchm deleted the 1440-pyproject-migration-new-positon-for-tests branch December 3, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Python tests out of package

3 participants